diff-review-strategy

# Diff Review Strategy ## PR Size Categories and Review Depth | Category | Lines Changed | Review Depth | Action | |----------|--------------|--------------|--------| | XS | 1–10 | Quick scan | Auto-approve if tests pass, typo/doc fixes | | S | 11–50 | Focused | Check edge cases, naming, one logic path | | M | 51–200 | Thorough | Full logic review, design check, test coverage | | L | 201–500 | Walkthrough | Request author explanation, check design first | | XL | 500+ | Split required | Block merge, ask to split into logical units | ### XS/S review checklist ``` [ ] Does the change do exactly what the title says? [ ] Are edge cases handled (null, empty, out-of-range)? [ ] Are variable names clear? [ ] Are tests updated or added? ``` ### M review checklist ``` [ ] Is the design the simplest solution? [ ] Are error paths handled? [ ] Is there duplication that should be extracted? [ ] Does it follow existing patterns in the codebase? [ ] Are there security implications (user input, auth)? [ ] Is the test coverage meaningful (not just happy path)? ``` ### L/XL protocol ``` 1. Read the PR description and linked ticket first 2. Review architecture/design before line-by-line reading 3. Request a walkthrough if intent is unclear 4. If XL: comment "Please split by [feature / layer / file]" ``` ## Performance Review Checklist ### Database ``` [ ] N+1 query? (loop calling DB inside a loop) [ ] Missing index on filtered/sorted column? [ ] SELECT * where only specific columns needed...