closeout-review

Solid

Run the final scope-controlled review before committing, pushing, or opening a PR. Use for closeout review, readiness checks, or self-review of a completed branch.

Code & Development 221 stars 13 forks Updated today Apache-2.0

Install

View on GitHub

Quality Score: 85/100

Stars 20%
78
Recency 20%
100
Frontmatter 20%
70
Documentation 15%
100
Issue Health 10%
50
License 10%
100
Description 5%
100

Skill Content

# Closeout Review This is the final gate for a non-trivial change. Read and apply the repository [`review`](../review/SKILL.md) skill, then resolve its findings locally. Do not post review comments. ## Freeze scope first Before reading findings, record the original request, owner/module boundary, changed files, and non-generated LOC against the base. This is the baseline; review must not silently redefine the task. ## Classify every validated finding - **In-scope blocker:** introduced by this diff, same owner boundary, and fixable without reframing the task. Fix now. - **Follow-up:** real but adjacent, optional, or a separate cleanup/bug class. Record it; do not absorb it. - **Stop and escalate:** requires a new contract, protocol, storage/API change, security confirmation, or product/design decision. Ask the user. When uncertain between blocker and follow-up, use follow-up. Findings are hypotheses: independently verify them before changing code. ## Converge Apply only in-scope blockers. Run the narrow test for each fix, then format, clippy with `-D warnings`, and the applicable broader tests. Use the [`mutation-check`](../mutation-check/SKILL.md) skill for scoped logic and the [`integration`](../integration/SKILL.md) skill for guest-visible/lifecycle changes. Re-run the review skill against the complete updated diff, not only the last fix commit. Stop after two non-converging review/fix cycles, if the diff grows beyond about twice the baseline without approval...

Details

Author
trailofbits
Repository
trailofbits/coop
Created
5 months ago
Last Updated
today
Language
Rust
License
Apache-2.0

Similar Skills

Semantically similar based on skill content — not just same category