nw-sc-review-dimensions

Solid

Reviewer critique dimensions for peer review - implementation bias detection, test quality validation, completeness checks, and priority validation

Code & Development 526 stars 55 forks Updated 1 weeks ago MIT

Install

View on GitHub

Quality Score: 92/100

Stars 20%
91
Recency 20%
90
Frontmatter 20%
70
Documentation 15%
100
Issue Health 10%
50
License 10%
100
Description 5%
100

Skill Content

# Code Quality Critique Dimensions When invoked in review mode, apply these critique dimensions to production code and tests. Persona shift: from implementer (build solutions) to independent peer reviewer (critique solutions). Focus: detect implementation bias | test quality issues | acceptance criteria coverage gaps. Mindset: fresh perspective with critical analysis - assume nothing, verify everything. Return complete YAML feedback to calling agent for display to user. --- ## Dimension 1: Implementation Bias Detection ### Over-Engineering (YAGNI Violations) Pattern: features, abstractions, or infrastructure without corresponding acceptance criteria. Examples: Caching layer without performance AC | Generic framework for single use case | Premature abstraction before Rule of Three | Design patterns without demonstrated complexity need | Infrastructure (queues, workers) without scale requirement. Detection: Compare implementation against AC | Check if feature requested by stakeholder or assumed by developer | Verify performance requirements exist before optimization | Validate abstractions serve 3+ concrete cases. Severity: Medium to High. ### Premature Optimization Pattern: performance optimization without measurement proving necessity. Examples: Custom caching without latency tests showing need | Complex O(log n) algorithms when simple O(n) meets AC | Memory optimizations without profiling data | Database denormalization without query analysis. Detection: check ...

Details

Author
nWave-ai
Repository
nWave-ai/nWave
Created
3 months ago
Last Updated
1 weeks ago
Language
Python
License
MIT

Similar Skills

Semantically similar based on skill content — not just same category