demand-first-review

Solid

Use when reviewing a PR, API, IPC channel, endpoint, parameter, type, config, or architectural extension point that adds or expands shared surface area, especially when consumers are absent, exports are unused or speculative, existing consumers are hack-heavy, forward compatibility is claimed, or multiple similar APIs may express one demand.

Code & Development 49,030 stars 4671 forks Updated today AGPL-3.0

Install

View on GitHub

Quality Score: 90/100

Stars 20%
100
Recency 20%
100
Frontmatter 20%
70
Documentation 15%
100
Issue Health 10%
50
License 10%
100
Description 5%
100

Skill Content

# Demand-First Review ## Principle Audit this causal chain before implementation quality: `root outcome or invariant → normalized demand → owning layer → contract → consumer` A call site proves usage, not legitimacy or shape. No call site raises the burden of proof, not an automatic rejection. Real demand may still have the wrong consumer or abstraction. ## Workflow Apply every step to each added API, channel, parameter, type, field, config, or extension point. ### 1. Reconstruct the demand List every new surface and exact consumed dimension; one valid consumer does not justify unused fields. Trace current and linked consumers to their user outcome, business rule, or system invariant. Inspect adjacent implementations, then ask: without the current API and history, would the demand remain and would this contract still be natural? Do not rely only on the PR description. ### 2. Audit consumer legitimacy - **Legitimate**: uses the correct owner and boundary. - **Compensating**: uses the nearest API and adds workarounds because the right capability is missing. - **Legacy-shaped**: reflects obsolete formats, transitional architecture, or history. - **Misplaced**: serves real demand in the wrong layer. Parsing, retries, sequencing, duplicated state, check-then-act, or cross-layer access signal compensation. Treat these as unmet upstream demand, never endorsement of the current surface. ### 3. Normalize related demands Strip names, historical formats, and workarounds fro...

Details

Author
CherryHQ
Repository
CherryHQ/cherry-studio
Created
2 years ago
Last Updated
today
Language
TypeScript
License
AGPL-3.0

Integrates with

Similar Skills

Semantically similar based on skill content — not just same category

API & Backend Listed

api-design-review

Review an API contract (REST or GraphQL) before or while it is implemented, checking resource naming, HTTP semantics, status codes, error shape, pagination, versioning, idempotency, and backward compatibility, and producing concrete revisions rather than abstract advice. Use when designing new endpoints, changing an existing API's surface, or reviewing a PR that adds or modifies API routes.

4 Updated 5 days ago
KhaledSaeed18
Code & Development Listed

developer-product-experience-review

Design or audit the end-user developer journey for an API, SDK, CLI, plugin, app integration, or developer platform across discovery, docs, installation, credentials, sandbox, first success, production readiness, diagnostics, support, certification, recertification, and retained use. Use when the primary artifact is a Developer Adoption Contract joining those surfaces into one measurable experience. Do not use for API or SDK implementation, API versioning policy alone, infrastructure capacity, developer quota or credit abuse policy, generic product abuse, or product analytics instrumentation alone.

1 Updated today
SylphxAI
Code & Development Listed

scrutinize

Outsider-perspective end-to-end review of a plan, PR, or code change. First questions intent and whether a simpler/more elegant approach would achieve the same goal, then traces the actual code path (not just the diff) to verify the change does what it claims. Output is concise, actionable, and every call carries its rationale. Trigger on /scrutinize and proactively whenever the user asks to review, audit, sanity-check, or get a second opinion on a plan, PR, diff, design doc, or proposed code change.

0 Updated yesterday
rcdelfin