abap-code-reviewlisted

# ABAP Code Review v3.0 — 12-Dimension Pre-Release Gate Structured peer review with cumulative tracking. Pipeline stages: - **Stage 3** (Proposal review): Architecture + design against 12 dims -> `REVIEW_1.md` - **Stage 7** (Code review): Implemented code vs Stage 3 findings -> `REVIEW_2.md` ## Prerequisites (auto-run) ```bash # Step 0 — Auto lint (mandatory, runs first) npm run abap:lint 2>&1 | tee reports/lint.txt # Step 0b — ATC check (if ADT available) npm run abap:review 2>&1 | tee reports/atc.txt ``` ## 12-Dimension Scoring Each dimension scored 0-100. Weighted average determines GO/NO-GO. ### Core (original 9) | # | Key | Weight | Description | Error Threshold | |---|---|---|---|---| | 1 | **SEC** | 2.0 | SQL injection, dynamic code, credential exposure, XSS in HTTP handler | CRITICAL=0 | | 2 | **AUTH** | 1.5 | Missing AUTHORITY-CHECK, S_DEVELOP gaps, ICF auth bypass | HIGH=0 | | 3 | **DATA** | 1.5 | No BAPIRET2 check, missing ENQUEUE, COMMIT without WAIT, LUW integrity | HIGH=0 | | 4 | **PERF** | 1.0 | SELECT in loop, SELECT *, missing WHERE, nested LOOP, HTTP timeout missing | MEDIUM<=2 | | 5 | **STD** | 1.0 | Deprecated statements, hardcoding, naming, Clean ABAP violations | MEDIUM<=5 | | 6 | **INTERFACE** | 1.0 | Hardcoded RFC dest, missing HTTP timeout, CORS misconfig, missing Content-Type | HIGH=0 | | 7 | **CHANGE** | 1.5 | Objects not in transport, shared INCLUDEs, cross-module impact | HIGH=0 | | 8 | **COMP** | 1.0 | PII exposure, missing change docs, GD