code-review-methodologylisted

Conduct two-stage code review: Stage 1 verifies spec compliance (criterion-to-code mapping), Stage 2 evaluates security, correctness, performance, and maintainability across 6 parallel facets with P1/P2/P3 synthesis and deduplication by file:line. For the Tests facet the reviewer derives expected behavior from the spec before reading the tests. Use when reviewing code changes or pull requests. This skill MUST be consulted because reviewing quality on broken logic is wasted effort, and unmet acceptance criteria must block merge.
synaptiai/synapti-marketplace · ★ 7 · Code & Development · score 79

Install: claude install-skill synaptiai/synapti-marketplace

# Code Review Methodology ## Contract Iron law: verify it works before verifying it is good; never review quality on code that misses the acceptance criteria. Required by `/flow:review`, `/flow:pr`, `code-reviewer`, `security-reviewer`. Returns a P1/P2/P3 finding set (`references/finding-schema.md`), a requirements map, and APPROVE, COMMENT or REQUEST_CHANGES. Skips: Stage 2 when Stage 1 finds >3 unmet criteria; on the 3rd+ cycle, only new P1s. ## Two-stage review **Stage 1, spec compliance.** Give each acceptance criterion one status: **Met** (implemented and testable), **Interpreted** (ambiguous; one reading implemented), **Partially Met**, **Not Addressed**. If Stage 1 fails, stop. **Stage 2, code quality**, in priority order: security, correctness, performance, maintainability. Never flag maintainability while security or correctness findings stand. ## 6-facet review Stage 1 on the main thread; facets fan out in parallel: | Facet | Focus | Agent / Skill | |---|---|---| | **Security** | OWASP top 10, secrets, authz, input validation | security-reviewer | | **Quality** | Logic, edge cases | code-reviewer | | **Conventions** | Commit, branch, PR format | convention-checker | | **Tests** | Coverage, quality commands, adequacy | test-runner | | **Error handling** | Unhandled errors, silent failures | error-handler-inspector | | **Claim verification** | Self-review claims vs files | holdout-validation | **Tests facet rule:** derive the expected behavior from the spec B