reviewlisted

# Review Fork-aware code review checklist. Run before merging any branch. Catches missing tests, security issues, and half-finished work before they land on main. ## When to Use This Skill - Before merging a feature branch - When asked to review a PR or set of changes - Before declaring a task complete ## Steps 1. **See the diff** — `git diff main...HEAD` for the full branch diff, or `git diff HEAD` for uncommitted changes. 2. **Check each changed file:** - Tests exist and pass for new behavior - No `TODO`, `TBD`, `not implemented`, `raise NotImplementedError`, or hardcoded placeholder values - No security issues: SQL injection, unvalidated external input, hardcoded secrets, path traversal - Follows existing patterns in this repo (naming, error handling, logging style) 3. **Run lint** — if the diff touches `core/`, `sap/`, `willow/`, `tests/`, or `scripts/`: ```bash bash scripts/lint_first_party.sh ``` Kart: `bash scripts/kart_lint_gate.sh` before commit/push scripts. Report failures verbatim; unused imports (ruff F401) block merge. 4. **Run the tests** — run the relevant test suite. Report the result verbatim. 5. **Report the verdict:** - **Passed**: list what was checked, confirm green, suggest merge if appropriate - **Failed**: list specific files and lines that need fixing before merge ## Rules - Never approve without running tests. "Looks right" is not a review. - Never approve Python changes without `lint_first_party.sh` green