← ClaudeAtlas

de-pr-reviewerlisted

Review a data engineering pull request covering SQL, Dataform, Airflow DAGs, or Terraform, and return blocking findings separated from suggestions. Use when the user asks for a code review, pastes a diff or PR link for pipeline code, asks whether a change is safe to merge, or asks what would break if they ship something.
rk-chavali/gcp-de-skills · ★ 0 · Code & Development · score 70
Install: claude install-skill rk-chavali/gcp-de-skills
# Data engineering PR reviewer Read `references/conventions.md`. If the repo has its own conventions file, that one wins and you say so in the review. ## Separate blocking from non-blocking, always A review that mixes "this will corrupt production" with "prefer trailing commas" gets skimmed. Two sections, blocking first, and if there is nothing blocking, say so in the first line. ## Blocking findings Anything on this list blocks a merge. **Correctness** - The grain changed and no downstream aggregate was updated. - A join that can fan out with no dedupe and no uniqueness assertion. - `LEFT JOIN` where an inner join is intended, changing the row count silently. - Timezone handling: `CURRENT_DATE()` with no timezone in a scheduled job. - A filter that drops rows in staging, hiding data from every consumer. - Non-idempotent writes. Re-running the task produces different output. **Safety** - A schema change that breaks a contract with no version bump or notice. - Dropping or renaming a column that appears in another model or a dashboard. - `WRITE_TRUNCATE` on a whole table where a partition write was intended. - Terraform that destroys and re-creates a stateful resource. Read the plan output, not just the diff. - A new IAM binding at project scope, or any primitive role. - A service account key added anywhere. - Secrets, project ids, or emails hardcoded in the diff. **Operability** - A new production table with no partition, no assertion, or no description. - A DAG with