subagent-reviewlisted

# /subagent-review — outside expert review Spawn ONE expert sub-agent via the `Agent` tool (`subagent_type: "general-purpose"`) to review the change the user names — a PR number, a branch, a commit range, or (with no argument) the current branch's diff against the default branch. ## Picking the reviewer Use the most senior role matching the change's domain, with a **standard engineering-discipline title** — the kind a real engineer would have on a resume (e.g. staff DBA, principal SRE, staff application security architect, principal frontend performance engineer, principal staff engineer). **Do not invent titles by concatenating feature names or internal project names from the diff.** ## The sub-agent's prompt Tell the sub-agent to read the diff itself: - PR: `gh pr diff <N>` - Branch/local (the usual case in this PR-less workflow): `git diff <default>...<branch>` or the given commit range and produce a review with exactly these sections: - **Pros** — what the change gains over the current default branch - **Cons** — what it loses or weakens; especially invariants, guards, or safety properties of the current code that this change drops, silently bypasses, or makes more fragile - **Industry-standard check** — is the design up to industry standard for that role? Name the standard where it diverges - **Non-standard solutions** — list ad-hoc patterns and note whether each is worth re-aligning - **Verdict** — ship / ship-with-nits / blockers (list the blockers)