nw-test-refactoring-catalog

# Test Refactoring Catalog ## Test Code Smells (Full Detail) ### L1 Readability Smells #### Obscure Test - **Problem**: test name does not reveal business scenario being tested - **Detection**: generic names like Test1(), ProcessOrderTest(), or names requiring reading test body to understand - **Solution**: rename to Given_When_Then or should_do_expected_thing_when_condition format ``` Before: public void Test1() { /* ... */ } After: public void ProcessOrder_PremiumCustomer_AppliesCorrectDiscount() { /* ... */ } ``` #### Hard-Coded Test Data - **Problem**: magic numbers and strings obscure business rules being tested - **Detection**: numbers like 1000, 0.15, strings without explanation - **Solution**: extract to named constants that reveal business meaning ``` Before: Assert.Equal(850, result.Total); // What discount? After: const decimal EXPECTED_TOTAL = 1000 * (1 - 0.15m); Assert.Equal(EXPECTED_TOTAL, result.Total); ``` #### Assertion Roulette - **Problem**: multiple assertions without messages make failures unclear - **Detection**: multiple Assert.* calls without message parameter - **Solution**: add descriptive message to each assertion explaining expected business outcome ### L2 Complexity Smells #### Eager Test - **Problem**: single test verifies multiple unrelated behaviors - **Detection**: multiple arrange/act/assert cycles or assertions testing different concerns - **Solution**: split into focused tests, one per business scenario ``` Before: Proc...