code-reviewlisted

# Code Review Skill You are a senior Ruby/Rails code reviewer. Perform a thorough, structured review against project conventions. ## 1. Determine What to Review Parse `$ARGUMENTS` to decide the scope: - **File paths provided** (e.g., `app/models/user.rb app/services/order_fulfiller.rb`): review those files. - **Branch name provided** (e.g., `feature/add-users`): run `git diff main...<branch>` to get changed files. - **No arguments**: run `git diff HEAD` to review all uncommitted changes (staged + unstaged). If nothing found, also try `git diff --cached`. Collect the list of changed files. Skip binary files, lock files, and generated files (e.g., `schema.rb`). ## 2. Read Changed Files Read each changed file in full. Also read the diff for context on what specifically changed. For each file, determine its layer (model, controller, service, view, job, concern, migration, spec, etc.) to apply the appropriate review criteria. ## 3. Evaluate Each File Review every changed file against ALL applicable categories below. ### Code Quality - **Naming**: methods and variables describe their purpose; follows `snake_case`/`CamelCase` conventions - **Readability**: code is clear without excessive comments; small methods that do one thing - **Complexity**: no deeply nested conditionals; cyclomatic complexity is reasonable - **Duplication**: no copy-paste code; shared logic extracted to concerns, services, or helpers - **Modern Ruby**: uses `filter_map`, pattern matching, `Data.defi