rseng-code-review

Solid

Covers reviewing existing code and whole projects, not just new diffs: structured codebase audits that produce ranked findings and then implement the agreed improvements, recurring project reviews after major tasks and milestones, review scoping by risk and tier, and turning review findings into tracked work and lessons. Use PROACTIVELY after major tasks and milestones, and when the user asks for a code review, codebase audit or health check of existing code, wants improvements suggested and applied, mentions reviewing the project after a milestone or before a release or submission, or when inherited or long-unreviewed code needs a structured pass. For diff-time pre-review of new work see rseng-pair-programming; for PR-time review process and rules see rseng-version-control-review.

Code & Development 14 stars 2 forks Updated 4 days ago MIT

Install

View on GitHub

Quality Score: 83/100

Stars 20%
39
Recency 20%
100
Frontmatter 20%
70
Documentation 15%
100
Issue Health 10%
80
License 10%
100
Description 5%
100

Skill Content

# Code and project review Most review attention goes to new diffs; most risk lives in the code nobody has looked at for a year. This skill covers the retrospective forms: reviewing the EXISTING codebase with findings ranked and then implemented, and reviewing the PROJECT on a cadence - after milestones, before releases and submissions. Division of labor: rseng-pair-programming owns diff-time pre-review of new work; rseng-version-control-review owns the review process and rules; this skill owns review as an undertaking on what is already there. Review-then-implement is a two-phase contract: findings first, agreement second, changes third - never silent rewriting under the review's flag. ## The codebase review Scope before depth - review the code that matters most: 1. Map risk: recently churned complex modules (rseng-software-metrics' hotspot map), result-bearing code paths (what feeds published numbers), security surfaces (rseng-security), and anything the tests do not reach (rseng-testing's coverage). Review THOSE deeply; skim the rest. 2. Sweep with the pack's lenses, each producing findings with file:line evidence: correctness and silent-failure modes (rseng-defensive-coding), numerical practice (rseng-numerical-accuracy), design and coupling (rseng-software-design), performance red flags on hot paths (rseng-performance-profiling), hygiene and dead code (rseng-code-quality), reproducibility hazards - unseeded randomness, unpinned environ...

Details

Author
fdiblen
Repository
fdiblen/rseng-agent-skills
Created
4 days ago
Last Updated
4 days ago
Language
Python
License
MIT

Similar Skills

Semantically similar based on skill content — not just same category

Code & Development Listed

code-review

Use for source-read-only review of a PR, diff, commit, migration, refactor, or implementation through its dependency cone. Not for root-cause diagnosis, authorised fixes, or browser/UX review; use diagnose, implement, or ui-ux-design.

1 Updated yesterday
mblauberg
Code & Development Listed

code-review

Use when the user wants a code review of a branch, PR, MR, or working diff against its acceptance criteria and declared scope, in whatever form they take in this repo. Triggers on "review my branch", "review this PR", "check this diff before I raise it", "is this ready to merge". Works with any language, delivery process, or issue tracker. Produces a structured verdict with blocking, warning, and suggestion findings; writes no source changes. Do NOT use to address or fix review findings (code-review-fix), to implement work (implement), to publish a review to a provider as its reviewer (merge-request-review), to sign off completion of a larger body of work (validate), or to review rendered UI (ux-design-review).

2 Updated 3 weeks ago
carinyaparc
Code & Development Listed

code-review

Review a diff the way a senior engineer does — design first, then spec conformance, correctness, complexity, and tests — reporting only findings with a demonstrated failure. Use when asked to review code, review a branch or PR, check changes before merging, audit a diff for bugs or security issues, or "is this safe to merge?".

1 Updated 1 months ago
artificialguybr