definition-of-done-reviewlisted
Install: claude install-skill enocgit/sdlc-kit
# definition-of-done-review
A consistent, team-specific final check. Generic `code-review` and `simplify` catch bugs and
cleanup; this verifies the change is actually *done* by our standard. Run it after them.
## Checklist — read it from AGENTS.md, don't rely on a copy
The **canonical Definition of Done lives in the project's `AGENTS.md`** ("Definition of Done"
section). Read it at run time and review the change against **that exact list**, item by item —
this skill deliberately embeds no copy, so a project that tightens or extends its DoD is
automatically reviewed against its own standard. (The sensitive-areas list is likewise canonical
in `AGENTS.md` → Sensitive areas.)
How to judge the items that need interpretation:
- **Acceptance criteria** — quote each criterion from the PRD/issue and map it to evidence.
- **Contract fidelity** — no undocumented endpoints/fields; types derived from the contract, not
hand-duplicated; any mismatch is a finding even if tests pass.
- **Tests / observed working** — green suite is necessary, not sufficient: the change must have
been run and observed (`run`/`verify`), and new logic covered, not just touched.
- **Docs** — `docs/architecture.md` if the system's shape changed; a new ADR if a decision was
made; the tracker issue reflects reality.
- **Security** — for sensitive-area changes, `security-review` was run with findings resolved and
`docs/security.md` updated.
## Output
Produce a pass/fail verdict per item with file:line e