qa-reviewlisted

# Code Review ## Objective Identify quality, security, and maintainability issues BEFORE merge. ## Native features first Claude Code ships a native **`/code-review`** that owns the review *execution*: effort levels from `low` to `max`, `--fix` to apply findings, `--comment` to post inline PR comments, and `ultra` for a multi-agent cloud review. Prefer it to run the review. **This skill's delta is the conventions the review is held to** — the checklist below (incl. the `substance-check.sh` gate native review does not run), the naming tables, and the severity taxonomy. Use them to brief or grade a native `/code-review` run, or as the manual protocol where the native command is unavailable. ## Instructions ### 1. Overview ```bash # View the changes git diff main...HEAD --stat git log main...HEAD --oneline ``` ### 2. Review checklist #### Code quality - [ ] Readability (clear names, short functions) - [ ] DRY (no duplication) - [ ] SOLID (single responsibility) - [ ] Reasonable complexity - [ ] No over-engineering (YAGNI: no speculative options/abstraction; could a stdlib/native/one-liner replace custom code?) #### Typing (TypeScript) - [ ] No `any` - [ ] Explicit types on public APIs - [ ] Well-defined interfaces #### Tests - [ ] Tests present and relevant - [ ] Edge cases covered - [ ] Mocks limited to I/O - [ ] Substance: no hollow tests / stubs — run `./scripts/substance-check.sh <changed-files>` (flags no-assertion / always-true / skipped / empty / stub; a green