soleri-deep-reviewlisted

# Deep Review — Architecture, Smells & Solution Quality Multi-pass code review that goes beyond surface lint. Analyzes structural health, code smells, architectural fitness, and solution quality. Works on any codebase — vault context is optional enrichment, not a requirement. ## Input The user provides a **target**: file, module, directory, PR diff, or function. If unclear, ask. ## The Three Passes ### Pass 1: Structural Analysis & Code Smells **Metrics** (gather by reading the code): - File length and function count - Cyclomatic complexity (nesting depth, branch count) - Dependency count — imports from how many modules? - Export surface area — how much is public vs. should be internal? **Structural Smells:** - **God file/class** — too many responsibilities, >300 lines with mixed concerns - **Long parameter lists** — function takes 5+ params (should be an object/config) - **Deep nesting** — 4+ levels of if/for/try/catch - **Shotgun surgery** — changing this code requires touching 5+ other files - **Primitive obsession** — passing raw strings/numbers instead of domain types - **Boolean blindness** — functions with multiple boolean params (`fn(true, false, true)`) **Duplication Smells:** - Copy-paste with slight variations - Repeated conditional logic — same if-chain in 3+ places - Parallel structures that always change together **Temporal Smells** (check git history): - Files that always change together but live in different modules → missing abstraction - Functio