java-code-reviewlisted

# Java Code Review Skill Systematic code review for the `tools` multi-module reactor. Start with the rules this repo *enforces at build time* — an ArchUnit or Surefire violation fails the build, not just review — then work through the general Java checks. ## When to Use - User says "review this code" / "check this PR" / "code review" - Before merging a PR - After implementing a feature ## Review Strategy 1. **Enforced-rules pass first** — anything below fails the build, so flag it as Critical regardless of how the code otherwise reads. 2. **Checklist pass** — null safety, exceptions, collections, concurrency, idioms, resources, API, performance. 3. **Summary** — findings by severity (Critical → Minor), with line references. ## Output Format ```markdown ## Code Review: [file/feature name] ### Critical - [Issue + line reference + suggestion] ### Improvements - [Suggestion + rationale] ### Minor/Style - [Nitpicks, optional improvements] ### Good Practices Observed - [Positive feedback] ``` --- ## 0. Repo rules the build enforces (check these FIRST) These are pinned by the module `.architecture` ArchUnit tests and the root Surefire config. Production code is `io.github.adamw7.*` (Java 25). Flag any violation as **Critical** — CI will reject it. | Rule | What to flag | |---|---| | **No `continue` / `break`** | Any use in *any* code (production or test). Refactor the loop. | | **No `System.out` / `System.err`** | In production code — log through log4j2 instead. (