architecture-review-criterialisted

# Architecture Review Criteria ## Overview 16 gates across 3 lenses, plus 1 cross-cutting escalation gate, applied by the `solution-architect-reviewer` agent to DESIGN artefacts. Gates enforce DDD correctness, Clean Architecture compliance, fitness for the stories in scope, cross-artefact consistency, the prohibition of negative or baseline-restating ADRs, and the integrity of the human-escalation protocol. **Applied by:** `solution-architect-reviewer` **Applied to:** ADRs, event models, component diagrams, context maps, interface contracts, consistency matrices, supersession plans, supersession registry, blocker files **Prior phase required:** DESIGN artefacts from `solution-architect` --- ## Gate Definitions ### Lens 1 — consistency-lens Evaluates: ADRs + supersession registry + diagrams + contracts + consistency matrices + supersession plans + blockers | Gate | Definition | Pass condition | Severity | |---|---|---|---| | G1 | Every structural commitment — whether visible in a diagram OR detected in the existing codebase by Phase 7.0 grep signatures (`ICommandBus\|IQueryBus\|CommandBus\|QueryBus`, `IEventStore\|EventStream`, `Saga\|ProcessManager`, cross-context ACL) — has a traceable `Accepted` ADR justification. Back-fill ADRs are required when production code carries a structural pattern not yet covered by any ADR. | Every structural element in diagrams AND every grep hit from the persona's Step 7.0 detection table references at least one `Accepted` ADR. | BLOCKE