← ClaudeAtlas

review-clean-codelisted

Use when: reviewing code against Clean Code principles (Uncle Bob) and SOLID at the function/class level — meaningful names, small functions, single level of abstraction, argument count, error handling, DRY, comment quality, and SOLID (SRP, OCP, LSP, ISP, DIP) as applied to individual classes and functions. Triggered by: "review clean code", "check clean code", "Uncle Bob review", "SOLID review", "review --clean-code", or dispatched by review-orchestrator. NOT for: architectural layer violations (review-architecture), naming convention formatting (review-style), logic correctness bugs (review-logic), or security (review-security-code).
MrCipherSmith/helyx · ★ 1 · Code & Development · score 71
Install: claude install-skill MrCipherSmith/helyx
# Review: Clean Code + SOLID Specialized reviewer for **Clean Code principles** (Robert C. Martin) and **SOLID** at the function and class level. Focuses on code in the current branch diff only. The goal is not stylistic nitpicking — every finding here points to a concrete maintainability, readability, or extensibility problem that will cause friction as the codebase grows. --- ## Workflow ``` Clean Code Review Progress: - [ ] Step 1: Read Job Context (if provided) - [ ] Step 2: Determine git scope (merge-base) - [ ] Step 3: Collect diff and changed file list - [ ] Step 4: Meaningful Names check - [ ] Step 5: Functions check (size, abstraction, arguments) - [ ] Step 6: Comments check - [ ] Step 7: Error Handling check - [ ] Step 8: DRY check - [ ] Step 9: SOLID check (SRP, OCP, LSP, ISP, DIP) - [ ] Step 10: Emit findings in unified format ``` --- ## Input Contract | Field | Type | Required | Description | |-------|------|----------|-------------| | `branch` | string | no | Branch to review. Defaults to current branch. | | `commit_range` | string | no | Explicit hash or range. Overrides merge-base detection. | | `context_doc` | string | no | Path to job context document. Read before reviewing. | --- ## Scope Detection See shared script: `skills/shared/git-merge-base.md` Run the script to determine `BASE_SHA`, then collect the diff: ```bash git diff --name-status "${BASE_SHA}" git diff "${BASE_SHA}" git ls-files --others --exclude-standard ``` Review scope: **only