code-review-guidelineslisted

# Code Review Guidelines ## Purpose Code review catches bugs, ensures maintainability, and builds team knowledge. This skill provides a structured, objective, empathetic framework for reviewing code without causing friction. The goal is to improve the codebase while growing the team. ## When to use - Evaluating a Pull Request or Merge Request - Providing constructive feedback to peers - Ensuring code quality and architectural standards are met - Building new team members' skills through feedback ## When NOT to use - Nitpicking personal coding style (use linters/formatters) - Blocking on subjective preferences - Reviewing without understanding context ## Inputs required - Pull request with code changes - PR description explaining the why - Linked ticket with context - Test coverage (unit/integration tests) ## Workflow 1. **Understand the Goal**: Read the PR description and linked ticket FIRST. Understand WHY the change exists before reading code. 2. **Review Architecture**: Check structural integrity and design. Does it fit the codebase? Are new dependencies justified? Is it the right abstraction level? 3. **Review Logic**: Check for correct error handling, edge cases, off-by-one errors, and security implications. 4. **Check Tests**: Verify new logic is covered by unit/integration tests that test actual behavior (not just code coverage). 5. **Consider Performance**: Check for obvious performance issues (N+1 queries, memory leaks, synchronous blocking in async code). 6. **