← ClaudeAtlas

lorekeeper-code-reviewerlisted

Lorekeeper-specific BLOCKER patterns, severity tiers, and review checklist — used when reviewing any PR touching src/lorekeeper/
Jessinra/Lorekeeper · ★ 3 · Code & Development · score 70
Install: claude install-skill Jessinra/Lorekeeper
# Lorekeeper Code Review Patterns Use this skill when reviewing any PR that changes `src/lorekeeper/` runtime code, services, handlers, or MCP server. These are project-specific patterns that general-purpose review prompts miss. **Incident-driven:** BLOCKER patterns 16-19 added after P0 Incident 2026-06-21 (Lorekeeper SQLite lock contention + infinite retry storm). See `docs/incidents/IR-002-lorekeeper-sqlite-lock-contention.md`. Patterns 20-24 added after LKPR-100 (server wiring, metrics, partial commits) and LKPR-67 (type migration, backup compatibility). Load alongside `github-code-review` for a complete review session. ## Severity Tiers Every review comment **must** carry a severity label. | Label | Tier | Merge impact | | ------------- | ---------- | --------------------------------- | | `blocker:` | 🔴 BLOCKER | **Must fix before merge** | | `issue:` | 🟠 MAJOR | Fix before merge or create ticket | | `suggestion:` | 🟡 MINOR | Fix encouraged, deferrable | | `nit:` | 🔵 NIT | Optional, never blocks | | `praise:` | ✅ | Acknowledge good work | **Merge contract:** PR is mergeable when all BLOCKERs resolved, all MAJORs resolved OR tracked, CI green, ≥1 human approval. ## How to Use This Skill 1. **Holistic review** — Before checking the diff, read every changed file in full, read adjacent files, and read the ticket/plan. Load `references/holistic-review.md` fo