odoo-code-reviewlisted

# Odoo Code Review Use this skill for Odoo-specific code review. Findings come first. Focus on bugs, security risks, behavioral regressions, performance problems, migration hazards, and missing tests before style cleanup. Official Odoo coding guidelines are still covered by [ODOO-CODING-GUIDELINES.md](ODOO-CODING-GUIDELINES.md), but review scope is broader than style. ## First Move Identify: - target Odoo version - addon/module scope - changed files or diff range - stable branch vs development branch - repo-specific conventions and checks - available local framework/tooling context: `$ODOO_SOURCE`, `$ODOO_TOOL_README`, `$ODOO_BASE_COMMAND` If a version-specific reference skill exists, consult it before reviewing version-sensitive behavior: - Odoo 17: `odoo-17.0` - Odoo 18: `odoo-18.0` - Odoo 19: `odoo-19.0` If `$ODOO_SOURCE` is set, inspect local framework code for APIs, XML syntax, assets, test helpers, and version-specific behavior before relying on memory. ## Review Workflow 1. Determine the review target: whole addon, diff, PR, commit range, or specific files. 2. Read the module manifest first, then relevant imports, models, views, security, data, controllers, tests, assets, reports, and docs. 3. Check official style/guideline concerns with [ODOO-CODING-GUIDELINES.md](ODOO-CODING-GUIDELINES.md). 4. Check Odoo behavior risks with the review checklist below. 5. Return findings ordered by severity with file/line references. 6. State checks run, checks not run, and