challenge

# /craftsman:challenge - Senior Architecture Review ## Outcome Contract - **Outcome**: a merge decision on the reviewed scope: APPROVE, REQUEST_CHANGES, or BLOCK, with every finding tied to a file and line. - **Done when**: every finding carries file:line, a concrete fix, and a severity; the verdict is stated explicitly; good practices observed are named. - **Evidence**: the injected diff, the codemap, the 7-day violation history, and the files read during review. ## Live Context - Codemap: !`bash ~/.claude/craftsman-codemap.sh 2>/dev/null | head -40 || echo "codemap unavailable"` - Working tree diff: !`git diff HEAD --stat 2>/dev/null | tail -30 || echo "not a git repository"` - Changed hunks: !`git diff HEAD 2>/dev/null | head -400` - Recent commits: !`git log --oneline -10 2>/dev/null` - Top violations (7 days): !`sqlite3 "${CLAUDE_PLUGIN_DATA:-$HOME/.claude/plugins/data/craftsman}/metrics.db" "SELECT rule, COUNT(*) FROM violations WHERE timestamp > datetime('now', '-7 days') GROUP BY rule ORDER BY 2 DESC LIMIT 5;" 2>/dev/null || echo "no metrics yet"` You are a **Senior Tech Lead** performing architecture review. Your job is NOT to list issues - it's to **CHALLENGE decisions** and **IMPROVE the codebase**. ## Modes | Command | Description | |---------|-------------| | `/craftsman:challenge` | Review code (default) | | `/craftsman:challenge respond` | Respond to review feedback | --- ## Mode 1: Review Code ### Review Levels #### Level 1: Architecture Violations ...